Ticket #1268 (closed defect: fixed)

Opened 14 months ago

Last modified 4 months ago

'shortlived' does not consider grace/keep

Reported by: daghf Owned by: phk
Priority: normal Milestone:
Component: build Version: trunk
Severity: normal Keywords:
Cc:

Description

Grace/keep is not taken into account when considering if an object should be put in transient storage.

See attached test case.

Attachments

grace-transient.vtc Download (390 bytes) - added by daghf 14 months ago.
test case
0001-Consider-keep-grace-when-choosing-transient.patch Download (1.5 KB) - added by gquintard 4 months ago.

Change History

Changed 14 months ago by daghf

test case

comment:1 Changed 14 months ago by daghf

  • Owner set to daghf

comment:2 Changed 5 months ago by phk

  • Owner changed from daghf to phk

Changed 4 months ago by gquintard

comment:3 Changed 4 months ago by gquintard

Update the ttl test in cache_fetch to test ttl+gracce+keep. Had to tweak an assert in storage_persistent.c the same way.

Note thish will make p00005.vtc fails if the patch from #1387 is not applied.

comment:4 Changed 4 months ago by Poul-Henning Kamp <phk@…>

  • Status changed from new to closed
  • Resolution set to fixed

In [e8e208b1095c174e264e138ef24d1dd7f19e2215]:

Fix the "shortlived" test to look a the sum of ttl + grace + keep
rather than just the ttl.

Fixes #1268
Spotted by: daghf
Partial fix by: gquintard

Note: See TracTickets for help on using tickets.