Ticket #1243 (closed defect: fixed)

Opened 16 months ago

Last modified 15 months ago

param.show -l default values listed as ^A for user/group (more?)

Reported by: kristian Owned by: phk
Priority: low Milestone:
Component: varnishd Version: trunk
Severity: minor Keywords:
Cc:

Description (last modified by kristian) (diff)

I'm parsing the output of param.show -l, particularly the default value right now.

For user and group, there is no default, however the value is not printed as blank, but an invisible ^A (ASCII 0x01) is printed instead, which complicates parsing as I do not expect non-printable characters.

Example result (yeah, some issues in the json still, but ignore that):

                 {
                        "name": "vcc_err_unref",
                        "value": "on",
                        "default": "on",
                        "unit": "bool",
                        "description": "Unreferenced VCL objects result in error."
                },
                 {
                        "name": "vcc_allow_inline_c",
                        "value": "on",
                        "default": "on",
                        "unit": "bool",
                        "description": "Allow inline C code in VCL."
                },
                 {
                        "name": "user",
                        "value": "nobody (65534)",
                        "default": "^A",
                        "unit": "",
                        "description": "The unprivileged user to run as.  Setting thiswill also set "group" to the specified user'sprimary group.NB: This parameter will not take any effect untilthe child process has been restarted."
                },

Or, using "varnishadm param.show user | less":


user                        nobody (65534)
                            Default is ^A
                            The unprivileged user to run as.  Setting this
                            will also set "group" to the specified user's
                            primary group.
                            
                            NB: This parameter will not take any effect until
                            the child process has been restarted.

(Note that for my terminal/shell, the ^A is not visible without | less)

This is a medium-fresh master/trunk Varnish.

Change History

comment:1 Changed 16 months ago by kristian

  • Description modified (diff)

comment:2 Changed 16 months ago by phk

  • Owner set to phk

comment:3 Changed 15 months ago by Poul-Henning Kamp <phk@…>

In [dabcce2cd278dc2a710777b90ada2aeff0cbadaa]:

Use the new param-default-setting ability, to simplify the magic
surrounding the privsep user/group setting code.

Fixes #1243

comment:4 Changed 15 months ago by Poul-Henning Kamp <phk@…>

  • Status changed from new to closed
  • Resolution set to fixed

(In [dabcce2cd278dc2a710777b90ada2aeff0cbadaa]) Use the new param-default-setting ability, to simplify the magic surrounding the privsep user/group setting code.

Fixes #1243

Note: See TracTickets for help on using tickets.