Ticket #1238 (closed defect: fixed)

Opened 16 months ago

Last modified 16 months ago

varnishd -p option runtime parameter splitting changes the command line as viewed by ps

Reported by: martin Owned by:
Priority: normal Milestone:
Component: varnishd Version: trunk
Severity: normal Keywords:
Cc:

Description

When varnishd parses the -p option argument on the '=' character, it replaces it with a '\0' to split it into two strings. This changes the command line as viewed by e.g. ps into a command line that is actually invalid, and can cause confusion with debugging start up scripts.

$ ./varnishd -p thread_pool_min=200 -d
$ ps auxww | grep varnishd
/usr/local/sbin/varnishd -p thread_pool_min 200 -d

Change History

comment:1 Changed 16 months ago by Martin Blix Grydeland <martin@…>

In [801f3a62f00eea3f02023650d2f3ac144240d538]:

Set the split character back to '=' after applying the runtime
parameter to preserve the arguments as seen e.g. ps.

Fixes: #1238

comment:2 Changed 16 months ago by Martin Blix Grydeland <martin@…>

  • Status changed from new to closed
  • Resolution set to fixed

(In [801f3a62f00eea3f02023650d2f3ac144240d538]) Set the split character back to '=' after applying the runtime parameter to preserve the arguments as seen e.g. ps.

Fixes: #1238

Note: See TracTickets for help on using tickets.