Ticket #1230 (closed defect: fixed)

Opened 17 months ago

Last modified 17 months ago

Refine header check in bin/varnishd/mgt/mgt.h, mgt_main.c for uClibc

Reported by: basile@… Owned by: phk
Priority: normal Milestone:
Component: varnishd Version: trunk
Severity: normal Keywords:
Cc:

Description

Because of the difference in how uClibc and glibc stack their header files, stdio.h indirectly brings in PTHREAD_CANCELED from pthread.h on a uClibc system, whereas it does not on a glibc system. This happens in mgt.h and mgt_main.c, and causes a (pre-)compile time failure. This patch refines the check in those files to take this fact into consideration.

See the downstream bug for more details:  https://bugs.gentoo.org/444294

Attachments

0001-Refine-header-check-in-bin-varnishd-mgt-mgt.h-mgt_ma.patch Download (1.7 KB) - added by basile@… 17 months ago.
Refine header check in bin/varnishd/mgt/mgt.h, mgt_main.c for uClibc

Change History

Changed 17 months ago by basile@…

Refine header check in bin/varnishd/mgt/mgt.h, mgt_main.c for uClibc

comment:1 Changed 17 months ago by phk

  • Owner set to phk
  • Component changed from build to varnishd

comment:2 Changed 17 months ago by Poul-Henning Kamp <phk@…>

In [881dcc3d7e2384ccf6f56de162ceebbe75d68384]:

Remove a pseudo-bogus test for pthreads in the manager process.

The subsequent cleanup/separation of .h files makes this test
much less important, and it's not like it is a conclusive or
comprehensive test in the first place.

Fixes #1230

comment:3 Changed 17 months ago by Poul-Henning Kamp <phk@…>

  • Status changed from new to closed
  • Resolution set to fixed

(In [881dcc3d7e2384ccf6f56de162ceebbe75d68384]) Remove a pseudo-bogus test for pthreads in the manager process.

The subsequent cleanup/separation of .h files makes this test much less important, and it's not like it is a conclusive or comprehensive test in the first place.

Fixes #1230

Note: See TracTickets for help on using tickets.