From slink at schokola.de Thu Jun 2 06:50:52 2022 From: slink at schokola.de (Nils Goroll) Date: Thu, 2 Jun 2022 08:50:52 +0200 Subject: *.body VMOD arguments Message-ID: <58d79058-5244-5748-de1c-2a3ded440676@schokola.de> Hi, we have two VIPS related to body access: * https://github.com/varnishcache/varnish-cache/wiki/VIP-30:-bereq.body_filters is about filters for the request body (which I am probably going to get to) * https://github.com/varnishcache/varnish-cache/wiki/VIP14:-*.body-access is about a new way to create a synth body But I can not remember if we ever talked about *.body as VMOD function/method arguments? If we did, please remind me. If not, I would suggest that we add those as a pointer to the respective objcore. Because VCL_BODY currently is typedef'd as const void *, we would need to change that and rewrite the existing VCC code for "VCL_BODY += ..." and "unset VCL_BODY", but I see no fundamental problem with that. Any ideas/comments? Thank you, Nils From phk at phk.freebsd.dk Thu Jun 2 06:56:36 2022 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Thu, 02 Jun 2022 06:56:36 +0000 Subject: *.body VMOD arguments In-Reply-To: <58d79058-5244-5748-de1c-2a3ded440676@schokola.de> References: <58d79058-5244-5748-de1c-2a3ded440676@schokola.de> Message-ID: <202206020656.2526ubMB069957@critter.freebsd.dk> -------- Nils Goroll writes: > But I can not remember if we ever talked about *.body as VMOD function/method > arguments? If we did, please remind me. > > If not, I would suggest that we add those as a pointer to the respective > objcore. Because VCL_BODY currently is typedef'd as const void *, we would > need to change that and rewrite the existing VCC code for "VCL_BODY += ..." and > "unset VCL_BODY", but I see no fundamental problem with that. We already have a BODY type ? const struct type BODY[1] = {{ .magic = TYPE_MAGIC, .name = "BODY", .noindent = 1, }}; -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk at FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From slink at schokola.de Fri Jun 3 14:56:24 2022 From: slink at schokola.de (Nils Goroll) Date: Fri, 3 Jun 2022 16:56:24 +0200 Subject: request body filters In-Reply-To: <58d79058-5244-5748-de1c-2a3ded440676@schokola.de> References: <58d79058-5244-5748-de1c-2a3ded440676@schokola.de> Message-ID: <5318e198-7c38-06cf-20e4-7f7f2bf97d1f@schokola.de> On 02.06.22 08:50, Nils Goroll wrote: > we have two VIPS related to body access: > > * https://github.com/varnishcache/varnish-cache/wiki/VIP-30:-bereq.body_filters > > is about filters for the request body (which I am probably going to get to) Related to that: Actually I think we are going to need two filters on the request body: * a VFP on the way into the cache (where we might want to use the request body with vmods and/or VCL) * a VDP when sending it to the backend. As a concrete example, one might want to uncompress the request body for vmod processing, but recompress it for delivery to the backend. Preserving the original request body would be another complication... Nils From scan-admin at coverity.com Mon Jun 6 09:39:43 2022 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Mon, 06 Jun 2022 09:39:43 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <629dcb5ecf902_23a66a2adf15bfb9a8944f9@prd-scan-dashboard-0.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrJbcjUxJo9eCHXi2QbgV6mmItSKtPrD4wtuBl7WlE3MQ-3D-3DVDdr_WyTzqwss9kUEGhvWd0SG502mTu1yasCtuh9h-2FD3Je49eaa706gU2T0whgXRaVJ1opYk6XrnfUMFrT6OpLdKi9yrXVvzXgnA9muBEda405h-2BsUAPeSe-2FgZsZ6e8-2FOu7Ka0xvltyTLi8SSyPHxmKQnyAW-2FTNuppYJmHtxNgF4qQdzpRzDDevNkwGGo3Ut7ElpExvx-2FUrbkF-2B8nJJmag4eWfWomxW8KK-2Bt-2F8tJpHiZ1Oyo-3D Build ID: 460134 Analysis Summary: New defects found: 0 Defects eliminated: 0 From slink at schokola.de Fri Jun 10 11:53:24 2022 From: slink at schokola.de (Nils Goroll) Date: Fri, 10 Jun 2022 13:53:24 +0200 Subject: bugwash prep 2022-06-13 Message-ID: <25aee248-7aee-7f4b-adc7-66cf7b390727@schokola.de> Hi, I will be on vacation next Monday and will try to join for bugwash, but if, for reasons(tm), I don't, then here's the update from my end: * https://github.com/varnishcache/varnish-cache/pull/3128 Add "via" backends (with endpoint preamble) I have added documentation, the PR is still ready from my perspective. It is clear that the implementation will change as we progress further (e.g. for adding CONNECT preambles, layering via-proxies or adding director support), but this is still the first step. * https://github.com/varnishcache/varnish-cache/pull/3553 std.now() and std.timed_call() I stand by my argument that we should add std.now() rather than change the semantics of now. We need to agree on how to proceed and we can optionally remove std.timed_call(), if that is controversial. * https://github.com/varnishcache/varnish-cache/pull/3572 feature: Transit buffer I have implemented the changes which we should add to avoid "polling" on the condition variable. The argument for this change is in https://github.com/varnishcache/varnish-cache/pull/3572#issuecomment-1143470754 * V1F, VFP_END, chunked processing, req.body access and caching. I have done quite a bit in this area around Dridis PR #3798 and left a summary in https://github.com/varnishcache/varnish-cache/pull/3798#issuecomment-1148576467 There would be more from my end, but any progress is good. See you soon! Nils From scan-admin at coverity.com Mon Jun 13 08:39:36 2022 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Mon, 13 Jun 2022 08:39:36 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <62a6f7c887ee4_682032ae877a0f9a824f7@prd-scan-dashboard-0.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrJbcjUxJo9eCHXi2QbgV6mmItSKtPrD4wtuBl7WlE3MQ-3D-3Dp3hR_WyTzqwss9kUEGhvWd0SG502mTu1yasCtuh9h-2FD3Je4-2FmfDUmNpG1LC3Pl-2FOxkEwVpo283lBwDnfP9j0R-2BwbxuRpEmOPuNnUcZiWRNf797x3Po7JeYr2DhorY0PzmAfAz9hW3XyrU8fZJJgADJfHBV-2BNBi5JWi9nAiOkMNpNK2jiFCkrluQKX8sATcd6V5-2BqzmrlQ7Nh11Z9FHFv4mSZxoE26ur3JO4CHXVcpIQo1VoI-3D Build ID: 461553 Analysis Summary: New defects found: 0 Defects eliminated: 0 From scan-admin at coverity.com Mon Jun 20 08:12:57 2022 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Mon, 20 Jun 2022 08:12:57 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <62b02c08a061d_d6a362aed076519a82263d@prd-scan-dashboard-0.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrJbcjUxJo9eCHXi2QbgV6mmItSKtPrD4wtuBl7WlE3MQ-3D-3DvoEd_WyTzqwss9kUEGhvWd0SG502mTu1yasCtuh9h-2FD3Je4-2Fi0Vrqx9R6aJpihWbw12BDN8o-2FSyXWRU35Wh8J2-2Fnm0tDZnFVaWMWwOsHBmKbPXCJyK5B9xdU9sKdo0-2Bw0InPVBDjJyAfaj4l4lrc3Jq2ZlFdz5oE69ieIz-2BJSjsWs4zY2r8BmE3p8Pa8N920-2BiSYg1bYWUYt12d4pB2EjSvjv5tworWKhmvzBiyq1bZkexX4-3D Build ID: 462883 Analysis Summary: New defects found: 0 Defects eliminated: 0 From scan-admin at coverity.com Mon Jun 20 09:37:12 2022 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Mon, 20 Jun 2022 09:37:12 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <62b03fc867a2_d780b2aed076519a822680@prd-scan-dashboard-0.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrJbcjUxJo9eCHXi2QbgV6mmItSKtPrD4wtuBl7WlE3MQ-3D-3DGq8O_WyTzqwss9kUEGhvWd0SG502mTu1yasCtuh9h-2FD3Je4-2BiIc37jl8DRKn6W11DDYf9SM6I5w-2FjXFJ9k0MilxowCH-2FFhhAtyHNdR2FgLqBQtk-2FdzdCXliclj3Swj1cugazWrGwPxgMG57duOuwBhiJXWrd1ig1Ozw9rVNOIVIUVYtkMFQuyQw7wFkoR5KbTUQWnEYkH-2FBR-2BqEDalQuUSSzr4LpbTl96cIfEhu-2BG9m7vQ80-3D Build ID: 462889 Analysis Summary: New defects found: 0 Defects eliminated: 0 From scan-admin at coverity.com Mon Jun 27 08:14:32 2022 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Mon, 27 Jun 2022 08:14:32 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <62b966e765709_1464312af0c1ce19a4905fd@prd-scan-dashboard-0.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrJbcjUxJo9eCHXi2QbgV6mmItSKtPrD4wtuBl7WlE3MQ-3D-3D-oFz_WyTzqwss9kUEGhvWd0SG502mTu1yasCtuh9h-2FD3Je488X4J-2Fl8PVVkisSWCKCJ0wcU8KisxkB-2FthhdAuMPNoI7YlPlWqpZVWt69-2B00vpMopTTFkyJQPE5WstcmYA29dtcTHDAIbF0lcx2L0T3KZiZb898pDsllThCHm8s03RtS-2BlJ0y2iX4NTmtyw8-2FZ3wBqzi3LC9pVlkZKwIJ8XRcsIKGZaNCkrRhnuF7yywTqlIQ-3D Build ID: 464226 Analysis Summary: New defects found: 0 Defects eliminated: 0