From scan-admin at coverity.com Sat Jan 4 09:30:05 2020 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Sat, 04 Jan 2020 09:30:05 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <5e105b1d2d36f_116d2ac5a47a0f503667a@appnode-2.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaZSCEJOPR4AEUn0hVASTtlJ23U2ffwbN1LtJbHcOCfQg-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQCKQ824-2B4u4WIgeHi9ABxLM-2BmB890HHkDegjopxdiC-2Bt3C94GlBvZub6d9aYX5zZEcaLOURwAjV5IwWb5jLd8oUdLN-2Fs6b8M4AX2-2FPLqWWPqqa9M-2B2TYzKt-2BOl47YcKDU-2FDf-2FslSMYU-2By-2FB-2BCctILtBxsPUPOI5VOzNa3jqQGQ5i43sEEg3QPycSe8pZCVXg1rf1LrODIwE8ZzHk6ik7mHv Build ID: 288314 Analysis Summary: New defects found: 0 Defects eliminated: 15 From scan-admin at coverity.com Sun Jan 5 11:40:57 2020 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Sun, 05 Jan 2020 11:40:57 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <5e11cb495ff68_41512ac5a47a0f503667c@appnode-2.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaZSCEJOPR4AEUn0hVASTtlJ23U2ffwbN1LtJbHcOCfQg-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQDfRd507Bq-2FCiAwK-2F1Mq-2FjZEVli1d-2BHZbfcN8KdvGieJV37Wa9sURkGx8KsyEWE-2F56I0RNCz72X2fU0d79KWDjLsvxS9ECTfg5-2FQNyQZXGyI9x-2Fp92hKKnCYKqzVE6WhIbN34NZpsKrBME6y87OuwVy8WwtKhT0fBt89s-2BGgTwFALaIjq-2FNLx2AnNeQoEJGMKQ8rntZ9d0zSKdlwalt1cg5 Build ID: 288559 Analysis Summary: New defects found: 0 Defects eliminated: 1 From scan-admin at coverity.com Sun Jan 12 11:41:12 2020 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Sun, 12 Jan 2020 11:41:12 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <5e1b05d769aad_256a2ac5a47a0f50366a9@appnode-2.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaZSCEJOPR4AEUn0hVASTtlJ23U2ffwbN1LtJbHcOCfQg-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQBisc3Jea9rI2e4-2FlitRJWwcltSfXnwTvXb2wWYwhlBphhTJ6si5uHkwMxQtWP40XsVqb6cUv-2FtBi9TOnHHPpBx-2BDpxQsD9B5rRBC8I5-2BMff3ZHqt1QybmZHzyaAlIXhPRbZ5wKkRNmPdba-2BneMpAWGoxAHVylE-2FczUwVRBl1M8bJjBnD5t-2Fq4N4oSGCxhvh3dzyEjGSYjchUMpuvoAHUfe Build ID: 289683 Analysis Summary: New defects found: 0 Defects eliminated: 16 From slink at schokola.de Thu Jan 16 16:05:49 2020 From: slink at schokola.de (Nils Goroll) Date: Thu, 16 Jan 2020 17:05:49 +0100 Subject: changelog automation? Message-ID: does anyone have experience with something like https://github.com/hawkowl/towncrier at first sight, would this help with our changelog maintenance? From dridi at varni.sh Thu Jan 16 16:26:37 2020 From: dridi at varni.sh (Dridi Boukelmoune) Date: Thu, 16 Jan 2020 16:26:37 +0000 Subject: changelog automation? In-Reply-To: References: Message-ID: On Thu, Jan 16, 2020 at 4:06 PM Nils Goroll wrote: > > does anyone have experience with something like > > https://github.com/hawkowl/towncrier > > at first sight, would this help with our changelog maintenance? It came to my attention recently because someone suggested that for Fedora's RPM changelogs, I gave up after the "philosophy" paragraph in the readme. Dridi From phk at phk.freebsd.dk Fri Jan 17 10:34:00 2020 From: phk at phk.freebsd.dk (Poul-Henning Kamp) Date: Fri, 17 Jan 2020 10:34:00 +0000 Subject: changelog automation? In-Reply-To: References: Message-ID: <98124.1579257240@critter.freebsd.dk> -------- In message , Nils Goroll writes: >does anyone have experience with something like > >https://github.com/hawkowl/towncrier > >at first sight, would this help with our changelog maintenance? The changelogs I know which are built by semi-automated means are useless commitlogs with the useful stuff omitted. The value of a changelog is *precisely* the editorial work which condenses the commitlog to a concise and useful document. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk at FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From scan-admin at coverity.com Sun Jan 19 11:41:03 2020 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Sun, 19 Jan 2020 11:41:03 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <5e24404ec0741_70542ac5a47a0f503665c@appnode-2.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaZSCEJOPR4AEUn0hVASTtlJ23U2ffwbN1LtJbHcOCfQg-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQBZBe5pN4rURm-2FBmFuCtoVA45DvQUELIUbOn-2Fd71XTnQyJ1vrPuqaXa7UcQ4VM6czfDjoCneb4oaIFU8aqVQFcwoCFcMk2qsCPCuCDe-2FLXkHMFOA6FCeXd-2BPd8U2dMWtWMWz6BjhyiDwTP-2Bd5fcJxaF44kOfzeS6MNo9oJk0dDEvyxnbvySijfz3Zt4i82QqCajyo8w9bozxZ-2Fn3RACXLTr Build ID: 290894 Analysis Summary: New defects found: 1 Defects eliminated: 16 If you have difficulty understanding any defects, email us at scan-admin at coverity.com, or post your question to StackOverflow at https://u2389337.ct.sendgrid.net/wf/click?upn=OgIsEqWzmIl4S-2FzEUMxLXL-2BukuZt9UUdRZhgmgzAKchwAzH1nH3073xDEXNRgHN6zzUI-2FRfbrE6mNOeeukHUQw-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQBZBe5pN4rURm-2FBmFuCtoVA45DvQUELIUbOn-2Fd71XTnQ-2BfkzJZSM9VAGaxH7zcIPUkmPwgVPZFbh62P3Lsg-2FaId5ROl-2FKWn3LhuPHOwNodYYUieJzJK57zChG-2FK2LUnrWpyDOJG2wQAJxA4BSSMptQzrt1LF15njSapfkh2HqKFW-2BVh7dkpk71mM1bdqknfk4lW0uSSo9iJmwjs-2Be8oasGb From scan-admin at coverity.com Sun Jan 26 11:41:06 2020 From: scan-admin at coverity.com (scan-admin at coverity.com) Date: Sun, 26 Jan 2020 11:41:06 +0000 (UTC) Subject: Coverity Scan: Analysis completed for varnish Message-ID: <5e2d7ad2366b3_5072ac5a47a0f5036631@appnode-2.mail> Your request for analysis of varnish has been completed successfully. The results are available at https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRaZSCEJOPR4AEUn0hVASTtlJ23U2ffwbN1LtJbHcOCfQg-3D-3D_wrU9d1VlqIiuL6N0zVMze4Ep-2FR7u99vtLlE-2BlH3ENQB0giXRx0AKsQfTXqtUsWRxuB1FcyLlM2Al70OdYGLlJmOp68b5KwdegWQsD7T0UoyLirGuW8BTS4ChFG0Sai0nK1N4Ne6Ef6xJcwQkl3197N8oHoeSrYC7TUqsVb1BETxY4SAf83UeQVO1EwU1vN8MyxE33UzaIbJcn8z3zoRLdAxBQFB47W5V-2BbMZDaopZ-2FrVq4wMUYQocfoVbArs9rbQ Build ID: 292069 Analysis Summary: New defects found: 0 Defects eliminated: 16 From martin.grigorov at gmail.com Thu Jan 30 11:13:39 2020 From: martin.grigorov at gmail.com (Martin Grigorov) Date: Thu, 30 Jan 2020 13:13:39 +0200 Subject: Fwd: Running vtest against master branch In-Reply-To: References: Message-ID: Hello, I am trying to run VTest against Varnish Cache master branch. Here are my steps: set VARNISH_FOLDER "/home/ubuntu/git/varnish" set VARNISH_CACHE "varnish-cache" set VARNISH_CACHE_BUILD "$VARNISH_FOLDER/varnish-cache-build" git clone https://github.com/varnishcache/$VARNISH_CACHE.git ./autogen.sh ./configure --with-unwind --enable-developer-warnings --enable-debugging-symbols --disable-stack-protector --with-persistent-storage --enable-asan --enable-ubsan --prefix=$VARNISH_CACHE_BUILD make make install cd .. git clone https://github.com/VTest/VTest.git vtest cd vtest env VARNISH_SRC="$VARNISH_FOLDER/varnish-cache" make varnishtest but here it fails with: cc \ -O2 -s -Wall -Werror \ -o varnishtest \ -DVTEST_WITH_VTC_VARNISH \ -DVTEST_WITH_VTC_LOGEXPECT \ -Isrc -Ilib -I/usr/local/include -pthread \ -I/home/ubuntu/git/varnish/varnish-cache/include \ src/*.c lib/*.c \ -L/usr/local/lib -lm -lpcre -lz \ -L/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -Wl,--rpath,/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -lvarnishapi src/vtc_main.c: In function ?cleaner_setup?: src/vtc_main.c:232:3: error: ignoring return value of ?nice?, declared with attribute warn_unused_result [-Werror=unused-result] (void)nice(1); /* Not important */ ^~~~~~~~~~~~~ cc1: all warnings being treated as errors Makefile:51: recipe for target 'varnishtest' failed make: *** [varnishtest] Error 1 To be able to overcome this I had to change FLAGS: diff --git Makefile Makefile index 996686f..c3ba32a 100644 --- Makefile +++ Makefile @@ -18,7 +18,7 @@ DEPS= ${SRCS} \ src/teken_state.h \ src/vtc_h2_dectbl.h -FLAGS= -O2 -s -Wall -Werror +FLAGS ?= -O2 -s -Wall -Werror INCS= -Isrc \ -Ilib \ and issue: env FLAGS="-O2 -s -Wall" VARNISH_SRC="/home/ubuntu/git/varnish/varnish-cache" make varnishtest but now the outcome is: cc \ -O2 -s -Wall \ -o varnishtest \ -DVTEST_WITH_VTC_VARNISH \ -DVTEST_WITH_VTC_LOGEXPECT \ -Isrc -Ilib -I/usr/local/include -pthread \ -I/home/ubuntu/git/varnish/varnish-cache/include \ src/*.c lib/*.c \ -L/usr/local/lib -lm -lpcre -lz \ -L/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -Wl,--rpath,/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -lvarnishapi src/vtc_main.c: In function ?cleaner_setup?: src/vtc_main.c:232:3: warning: ignoring return value of ?nice?, declared with attribute warn_unused_result [-Wunused-result] (void)nice(1); /* Not important */ ^~~~~~~~~~~~~ //usr/lib/aarch64-linux-gnu/libasan.so.4: warning: the use of `tmpnam' is dangerous, better use `mkstemp' //usr/lib/aarch64-linux-gnu/libasan.so.4: warning: the use of `tempnam' is dangerous, better use `mkstemp' //usr/lib/aarch64-linux-gnu/libasan.so.4: warning: the use of `tmpnam_r' is dangerous, better use `mkstemp' No tests are executed. As you might have noticed I test on aarch64 architecture. Do I need to do something more ? Regards, Martin -------------- next part -------------- An HTML attachment was scrubbed... URL: From martin.grigorov at gmail.com Thu Jan 30 09:21:26 2020 From: martin.grigorov at gmail.com (Martin Grigorov) Date: Thu, 30 Jan 2020 11:21:26 +0200 Subject: Fwd: Running vtest against master branch In-Reply-To: References: Message-ID: Hello, I am trying to run VTest against Varnish Cache master branch. Here are my steps: set VARNISH_FOLDER "/home/ubuntu/git/varnish" set VARNISH_CACHE "varnish-cache" set VARNISH_CACHE_BUILD "$VARNISH_FOLDER/varnish-cache-build" git clone https://github.com/varnishcache/$VARNISH_CACHE.git ./autogen.sh ./configure --with-unwind --enable-developer-warnings --enable-debugging-symbols --disable-stack-protector --with-persistent-storage --enable-asan --enable-ubsan --prefix=$VARNISH_CACHE_BUILD make make install cd .. git clone https://github.com/VTest/VTest.git vtest cd vtest env VARNISH_SRC="$VARNISH_FOLDER/varnish-cache" make varnishtest but here it fails with: cc \ -O2 -s -Wall -Werror \ -o varnishtest \ -DVTEST_WITH_VTC_VARNISH \ -DVTEST_WITH_VTC_LOGEXPECT \ -Isrc -Ilib -I/usr/local/include -pthread \ -I/home/ubuntu/git/varnish/varnish-cache/include \ src/*.c lib/*.c \ -L/usr/local/lib -lm -lpcre -lz \ -L/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -Wl,--rpath,/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -lvarnishapi src/vtc_main.c: In function ?cleaner_setup?: src/vtc_main.c:232:3: error: ignoring return value of ?nice?, declared with attribute warn_unused_result [-Werror=unused-result] (void)nice(1); /* Not important */ ^~~~~~~~~~~~~ cc1: all warnings being treated as errors Makefile:51: recipe for target 'varnishtest' failed make: *** [varnishtest] Error 1 To be able to overcome this I had to change FLAGS: diff --git Makefile Makefile index 996686f..c3ba32a 100644 --- Makefile +++ Makefile @@ -18,7 +18,7 @@ DEPS= ${SRCS} \ src/teken_state.h \ src/vtc_h2_dectbl.h -FLAGS= -O2 -s -Wall -Werror +FLAGS ?= -O2 -s -Wall -Werror INCS= -Isrc \ -Ilib \ and issue: env FLAGS="-O2 -s -Wall" VARNISH_SRC="/home/ubuntu/git/varnish/varnish-cache" make varnishtest but now the outcome is: cc \ -O2 -s -Wall \ -o varnishtest \ -DVTEST_WITH_VTC_VARNISH \ -DVTEST_WITH_VTC_LOGEXPECT \ -Isrc -Ilib -I/usr/local/include -pthread \ -I/home/ubuntu/git/varnish/varnish-cache/include \ src/*.c lib/*.c \ -L/usr/local/lib -lm -lpcre -lz \ -L/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -Wl,--rpath,/home/ubuntu/git/varnish/varnish-cache/lib/libvarnishapi/.libs \ -lvarnishapi src/vtc_main.c: In function ?cleaner_setup?: src/vtc_main.c:232:3: warning: ignoring return value of ?nice?, declared with attribute warn_unused_result [-Wunused-result] (void)nice(1); /* Not important */ ^~~~~~~~~~~~~ //usr/lib/aarch64-linux-gnu/libasan.so.4: warning: the use of `tmpnam' is dangerous, better use `mkstemp' //usr/lib/aarch64-linux-gnu/libasan.so.4: warning: the use of `tempnam' is dangerous, better use `mkstemp' //usr/lib/aarch64-linux-gnu/libasan.so.4: warning: the use of `tmpnam_r' is dangerous, better use `mkstemp' No tests are executed. As you might have noticed I test on aarch64 architecture. Do I need to do something more ? Regards, Martin -------------- next part -------------- An HTML attachment was scrubbed... URL: From slink at schokola.de Thu Jan 30 12:49:27 2020 From: slink at schokola.de (Nils Goroll) Date: Thu, 30 Jan 2020 13:49:27 +0100 Subject: Fwd: Running vtest against master branch In-Reply-To: References: Message-ID: <2fed63cf-8bee-d083-689d-cce5f985b386@schokola.de> Hi, On 30/01/2020 12:13, Martin Grigorov wrote: > Hello, > > I am trying to run VTest against Varnish Cache master branch. As of now, vtest is bundled in varnish-cache as varnishtest. I made a previous attempt to make varnish-cache use vtest, but that was not accepted at the time: https://github.com/varnishcache/varnish-cache/pull/2838 Nils -------------- next part -------------- An HTML attachment was scrubbed... URL: From martin.grigorov at gmail.com Thu Jan 30 13:26:41 2020 From: martin.grigorov at gmail.com (Martin Grigorov) Date: Thu, 30 Jan 2020 15:26:41 +0200 Subject: Fwd: Running vtest against master branch In-Reply-To: <2fed63cf-8bee-d083-689d-cce5f985b386@schokola.de> References: <2fed63cf-8bee-d083-689d-cce5f985b386@schokola.de> Message-ID: Hi, On Thu, Jan 30, 2020 at 2:49 PM Nils Goroll wrote: > Hi, > > On 30/01/2020 12:13, Martin Grigorov wrote: > > Hello, > > I am trying to run VTest against Varnish Cache master branch. > > As of now, vtest is bundled in varnish-cache as varnishtest. > > I made a previous attempt to make varnish-cache use vtest, but that was > not accepted at the time: > https://github.com/varnishcache/varnish-cache/pull/2838 > Thanks for the answer! What is the proper way to run the tests ? I see a folder "bin/varnishtest/". There is a Makefile there but I don't see the goal that runs the tests. I've also found "tools/vtest.sh" but it clones varnish-cache, generates SSH key pair and asks me to send the public key to PHK. It seems this script is intended for the dev team. > Nils > -------------- next part -------------- An HTML attachment was scrubbed... URL: From martin.grigorov at gmail.com Thu Jan 30 13:27:36 2020 From: martin.grigorov at gmail.com (Martin Grigorov) Date: Thu, 30 Jan 2020 15:27:36 +0200 Subject: Fwd: Running vtest against master branch In-Reply-To: References: <2fed63cf-8bee-d083-689d-cce5f985b386@schokola.de> Message-ID: On Thu, Jan 30, 2020 at 3:26 PM Martin Grigorov wrote: > Hi, > > On Thu, Jan 30, 2020 at 2:49 PM Nils Goroll wrote: > >> Hi, >> >> On 30/01/2020 12:13, Martin Grigorov wrote: >> >> Hello, >> >> I am trying to run VTest against Varnish Cache master branch. >> >> As of now, vtest is bundled in varnish-cache as varnishtest. >> >> I made a previous attempt to make varnish-cache use vtest, but that was >> not accepted at the time: >> https://github.com/varnishcache/varnish-cache/pull/2838 >> > Thanks for the answer! > > What is the proper way to run the tests ? > I see a folder "bin/varnishtest/". There is a Makefile there but I don't > see the goal that runs the tests. > "make check" maybe ?! but it leads to such output here: FAIL: tests/a00000.vtc SKIP: tests/a00001.vtc SKIP: tests/a00002.vtc SKIP: tests/a00003.vtc SKIP: tests/a00004.vtc .... > I've also found "tools/vtest.sh" but it clones varnish-cache, generates > SSH key pair and asks me to send the public key to PHK. It seems this > script is intended for the dev team. > > >> Nils >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From slink at schokola.de Thu Jan 30 16:33:49 2020 From: slink at schokola.de (Nils Goroll) Date: Thu, 30 Jan 2020 17:33:49 +0100 Subject: Fwd: Running vtest against master branch In-Reply-To: References: <2fed63cf-8bee-d083-689d-cce5f985b386@schokola.de> Message-ID: <50102238-3940-7992-4159-dcf490630d98@schokola.de> On 30/01/2020 14:27, Martin Grigorov wrote: > > "make check" maybe ?! Yes You can also call varnishtest directly, for example ??? cd bin/varnishtest ??? ./varnishtest -i -j 50 tests/*.vtc -i instructs varnishtest to use the varnish binaries from the build tree. FAIL: tests/a00000.vtc SKIP: tests/a00001.vtc SKIP: tests/a00002.vtc SKIP: tests/a00003.vtc SKIP: tests/a00004.vtc This would be an indication that your varnishtest does not work in the first place. The .log files should tell you more Nils