[PATCH] Get rid of ban_url/ban.url

Tollef Fog Heen tfheen at varnish-software.com
Mon Nov 26 09:28:05 CET 2012


]] Poul-Henning Kamp

> --------
> In message <1353665181-23260-1-git-send-email-tfheen at varnish-software.com>, Tol
> lef Fog Heen writes:
> 
> >ban.url is confusing as it takes a regular expression rather than a
> >fixed string, so get rid of it in favour of people being explicit and
> >using ban req.url ~ /foo
> 
> My only reservation is that backwards-compat issue.

Yeah, on the other hand, I see people getting confused by it, and the
change when upgrading is pure syntax.

> When did we deprecate ban.url ?  Was that in 2.x ?  If so, go for it...

It hasn't really been marked as deprecated (so we could still allow it,
just remove the docs for it) and then remove the implementation in the
next version.  ban() (or rather, purge()) got added to some 2.x version,
at which point purge.url/ban.url was slightly deprecated.

-- 
Tollef Fog Heen
Technical lead | Varnish Software AS
t: +47 21 98 92 64
We Make Websites Fly!



More information about the varnish-dev mailing list