<div dir="ltr">Thank you. Happy new year to you as well.<div><br></div><div>I saw this after I committed it and pushed a workaround.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 1, 2020 at 8:59 AM Dridi Boukelmoune <dridi@varni.sh> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Jan 1, 2020 at 1:10 AM Federico G. Schwindt <<a href="mailto:fgsch@lodoss.net" target="_blank">fgsch@lodoss.net</a>> wrote:<br>
><br>
><br>
> commit f7ef41daa750a5269e851c08650524a87246fa0d<br>
> Author: Federico G. Schwindt <<a href="mailto:fgsch@lodoss.net" target="_blank">fgsch@lodoss.net</a>><br>
> Date:   Wed Jan 1 00:21:10 2020 +0000<br>
><br>
>     Plug minor leak<br>
><br>
> diff --git a/bin/varnishtest/vtc_client.c b/bin/varnishtest/vtc_client.c<br>
> index 2722488a1..7f62e8dbd 100644<br>
> --- a/bin/varnishtest/vtc_client.c<br>
> +++ b/bin/varnishtest/vtc_client.c<br>
> @@ -205,6 +205,8 @@ client_connect(struct vtclog *vl, struct client *c)<br>
>   * Client thread<br>
>   */<br>
><br>
> +typedef void (*cleanup_f)(void *);<br>
> +<br>
<br>
Doesn't build everywhere:<br>
<br>
<a href="https://varnish-cache.org/vtest/attachment_f7ef41daa750a5269e851c08650524a87246fa0d_SunOS_i86pc_5.11_1.04_32_gcc4.7_uplex_distcheck.txt" rel="noreferrer" target="_blank">https://varnish-cache.org/vtest/attachment_f7ef41daa750a5269e851c08650524a87246fa0d_SunOS_i86pc_5.11_1.04_32_gcc4.7_uplex_distcheck.txt</a><br>
<br>
Happy new year!<br>
<br>
>  static void *<br>
>  client_thread(void *priv)<br>
>  {<br>
> @@ -222,6 +224,7 @@ client_thread(void *priv)<br>
><br>
>         vsb = macro_expand(vl, c->connect);<br>
>         AN(vsb);<br>
> +       pthread_cleanup_push((cleanup_f)VSB_delete, vsb);<br>
>         c->addr = VSB_data(vsb);<br>
><br>
>         if (c->repeat == 0)<br>
> @@ -243,8 +246,9 @@ client_thread(void *priv)<br>
>                 VTCP_close(&fd);<br>
>         }<br>
>         vtc_log(vl, 2, "Ending");<br>
> -       VSB_destroy(&vsb);<br>
>         pthread_cleanup_pop(0);<br>
> +       pthread_cleanup_pop(0);<br>
> +       VSB_delete(vsb);<br>
>         vtc_logclose(vl);<br>
>         return (NULL);<br>
>  }<br>
> _______________________________________________<br>
> varnish-commit mailing list<br>
> <a href="mailto:varnish-commit@varnish-cache.org" target="_blank">varnish-commit@varnish-cache.org</a><br>
> <a href="https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit" rel="noreferrer" target="_blank">https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit</a><br>
</blockquote></div>