[3.0] 4dd65b9 Fix a classic programmer bug, spotted by the increasingly eagle-eyed LLVM C-compiler.

Tollef Fog Heen tfheen at varnish-cache.org
Wed Aug 17 11:25:34 CEST 2011


commit 4dd65b9c30d47bac6a9f17e875f9442c395ea0ea
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Aug 1 11:16:14 2011 +0000

    Fix a classic programmer bug, spotted by the increasingly eagle-eyed
    LLVM C-compiler.
    
    You have no idea how much or how long (20+ years!) I have missed having
    an alternative to GCC.
    
    Remember:
    
      Mono cultures are particularly bad for you, when they are good for you
    
    Kudos to:       The LLVM team.

diff --git a/bin/varnishtest/vtc_varnish.c b/bin/varnishtest/vtc_varnish.c
index e0f7c21..2b6e3d4 100644
--- a/bin/varnishtest/vtc_varnish.c
+++ b/bin/varnishtest/vtc_varnish.c
@@ -206,7 +206,7 @@ varnish_thread(void *priv)
 	(void)VTCP_nonblocking(v->fds[0]);
 	while (1) {
 		fds = &fd;
-		memset(fds, 0, sizeof fds);
+		memset(fds, 0, sizeof *fds);
 		fds->fd = v->fds[0];
 		fds->events = POLLIN;
 		i = poll(fds, 1, 1000);



More information about the varnish-commit mailing list