r4903 - in trunk/varnish-cache/bin: . varnishd varnishncsa varnishtest
phk at varnish-cache.org
phk at varnish-cache.org
Sat Jun 5 15:21:13 CEST 2010
Author: phk
Date: 2010-06-05 15:21:13 +0200 (Sat, 05 Jun 2010)
New Revision: 4903
Modified:
trunk/varnish-cache/bin/flint.lnt
trunk/varnish-cache/bin/varnishd/flint.lnt
trunk/varnish-cache/bin/varnishncsa/flint.lnt
trunk/varnish-cache/bin/varnishtest/flint.lnt
Log:
More FlexeLint centralization
Modified: trunk/varnish-cache/bin/flint.lnt
===================================================================
--- trunk/varnish-cache/bin/flint.lnt 2010-06-05 13:20:16 UTC (rev 4902)
+++ trunk/varnish-cache/bin/flint.lnt 2010-06-05 13:21:13 UTC (rev 4903)
@@ -1,12 +1,41 @@
-passes=3
+-ffc // No automatic custody
+
///////////////////////////////////////////////////////////////////////
// ../../config.h magic
-header(../../config.h)
+libh ../../config.h
--efile(451, ../../config.h)
+-efile(451, ../../config.h) // No include guard
///////////////////////////////////////////////////////////////////////
+// varargs stuff
+
+-emacro((???), va_arg) // 415, 416, 416, 661, 662, 796, 797 ...
+
+///////////////////////////////////////////////////////////////////////
// assert() support, common to libvarnish and libvarnishapi
-sem(vas_fail, r_no)
+
+///////////////////////////////////////////////////////////////////////
+// Ignore return values OK for these functions
+
+-esym(534, printf)
+-esym(534, fprintf)
+-esym(534, sprintf)
+
+-esym(534, memset)
+-esym(534, memcpy)
+-esym(534, memmove)
+
+-esym(534, strcat)
+-esym(534, strcpy)
+-esym(534, strlcpy)
+
+-esym(534, vsb_cat)
+-esym(534, vsb_bcat)
+-esym(534, vsb_putc)
+-esym(534, vsb_printf)
+-esym(534, vsb_vprintf)
+-esym(534, vsb_putc)
Modified: trunk/varnish-cache/bin/varnishd/flint.lnt
===================================================================
--- trunk/varnish-cache/bin/varnishd/flint.lnt 2010-06-05 13:20:16 UTC (rev 4902)
+++ trunk/varnish-cache/bin/varnishd/flint.lnt 2010-06-05 13:21:13 UTC (rev 4903)
@@ -110,8 +110,6 @@
+libh mgt_event.h
--emacro((???),va_arg) // the va_arg() macro can yield 415, 416, 661, 662
- // 796 and 797 (out-of-bounds errors).
-elib(123) // size is both a variable and a macro with args
-emacro(736, isnan) // isnanf
-efile(766, ../../config.h)
@@ -134,8 +132,6 @@
-sem(WS_Init, custodial(2))
-sem(http_Setup, custodial(2))
--ffc // No automatic custody
-
-e455 // thread lock
-e458 // unprotected read
-e763 // Redundant declaration for symbol '...' previously declared
@@ -156,22 +152,6 @@
-esym(759, vcc_ProcAction) // could be moved to module
-esym(714, vcc_ProcAction) // not ref.
--esym(534, sprintf) // Ignoring return value of function
--esym(534, asprintf) // Ignoring return value of function
--esym(534, printf) // Ignoring return value of function
--esym(534, fprintf) // Ignoring return value of function
--esym(534, memset) // Ignoring return value of function
--esym(534, memcpy) // Ignoring return value of function
--esym(534, memmove) // Ignoring return value of function
--esym(534, strcpy) // Ignoring return value of function
--esym(534, vsb_printf) // Ignoring return value of function
--esym(534, vsb_vprintf) // Ignoring return value of function
--esym(534, vsb_cat) // Ignoring return value of function
--esym(534, vsb_bcat) // Ignoring return value of function
--esym(534, vsb_putc) // Ignoring return value of function
--esym(534, strcat) // Ignoring return value of function
--esym(534, strcpy) // Ignoring return value of function
--esym(534, strlcpy) // Ignoring return value of function
-esym(765, panicstr) // Could be static
-emacro(506, isnan, isfinite) // constant value boolean
Modified: trunk/varnish-cache/bin/varnishncsa/flint.lnt
===================================================================
--- trunk/varnish-cache/bin/varnishncsa/flint.lnt 2010-06-05 13:20:16 UTC (rev 4902)
+++ trunk/varnish-cache/bin/varnishncsa/flint.lnt 2010-06-05 13:21:13 UTC (rev 4903)
@@ -4,8 +4,6 @@
// Fix strchr() semtics, it can only return NULL if arg2 != 0
-sem(strchr, 1p, type(1), 2n == 0 ? (@p < 1p) : (@p < 1p || @p == 0 ))
--ffc // No automatic custody
-
-e763 // Redundant declaration for symbol '...' previously declared
-e726 // Extraneous comma ignored
-e728 // Symbol ... not explicitly initialized
@@ -17,14 +15,6 @@
-emacro((826), TAILQ_PREV) // Suspicious pointer-to-pointer conversion (area too small)
--esym(534, printf) // Ignoring return value of function
--esym(534, fprintf) // Ignoring return value of function
--esym(534, memset) // Ignoring return value of function
--esym(534, memcpy) // Ignoring return value of function
--esym(534, memmove) // Ignoring return value of function
--esym(534, strcpy) // Ignoring return value of function
--esym(534, vsb_printf) // Ignoring return value of function
--esym(534, vsb_cat) // Ignoring return value of function
// cache.h
-emacro(506, INCOMPL) // Constant value Boolean
Modified: trunk/varnish-cache/bin/varnishtest/flint.lnt
===================================================================
--- trunk/varnish-cache/bin/varnishtest/flint.lnt 2010-06-05 13:20:16 UTC (rev 4902)
+++ trunk/varnish-cache/bin/varnishtest/flint.lnt 2010-06-05 13:21:13 UTC (rev 4903)
@@ -1,8 +1,6 @@
+libh mgt_event.h
--emacro((???),va_arg) // the va_arg() macro can yield 415, 416, 661, 662
- // 796 and 797 (out-of-bounds errors).
-elib(123) // size is both a variable and a macro with args
-emacro(736, isnan) // isnanf
-efile(766, ../../config.h)
@@ -11,8 +9,6 @@
-esym(528, svnid)
--ffc // No automatic custody
-
-e712 // 14 Info 712 Loss of precision (___) (___ to ___)
-e747 // 16 Info 747 Significant prototype coercion (___) ___ to ___
@@ -46,22 +42,6 @@
-emacro(774, REPLACE) // if(bool) always true
-emacro(506, REPLACE) // const bool
//
--esym(534, sprintf) // Ignoring return value of function
-// -esym(534, asprintf) // Ignoring return value of function
--esym(534, printf) // Ignoring return value of function
--esym(534, fprintf) // Ignoring return value of function
--esym(534, memset) // Ignoring return value of function
-// -esym(534, memcpy) // Ignoring return value of function
-// -esym(534, memmove) // Ignoring return value of function
-// -esym(534, strcpy) // Ignoring return value of function
--esym(534, vsb_printf) // Ignoring return value of function
--esym(534, vsb_cat) // Ignoring return value of function
--esym(534, vsb_bcat) // Ignoring return value of function
--esym(534, vsb_putc) // Ignoring return value of function
--esym(534, strcat) // Ignoring return value of function
--esym(534, strcpy) // Ignoring return value of function
--esym(534, strlcpy) // Ignoring return value of function
-//
// -emacro(506, isnan) // constant value boolean
// -emacro(747, isnan) // significant coersion
// -emacro(506, assert) // constant value boolean
More information about the varnish-commit
mailing list