r1942 - trunk/varnish-cache/bin/varnishd

[Anders Nordby]

Hi,

After applying this patch to Varnish 1.1.1 (+commit 1913, the fix for
ticket #150), I got a sig10 crash:

Sep 12 13:51:14 cache10 kernel: pid 73320 (varnishd), uid 0: exited on
signal 10 (core dumped)

Backtrace of the core dump shows:

# gdb -c varnishd.core -s
/usr/local/sbin/varnishd 
GNU gdb 6.1.1 [FreeBSD]
Copyright 2004 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you
are
welcome to change it and/or distribute copies of it under certain
conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for
details.
This GDB was configured as "amd64-marcel-freebsd"...
Core was generated by `varnishd'.
Program terminated with signal 10, Bus error.
#0  0x00000000004089f0 in vbe_sock_conn (ai=0xd0d0d0d0d0d0d0d0)
    at cache_backend.c:158
158             s = socket(ai->ai_family, ai->ai_socktype,
ai->ai_protocol);
(gdb) bt
#0  0x00000000004089f0 in vbe_sock_conn (ai=0xd0d0d0d0d0d0d0d0)
    at cache_backend.c:158
#1  0x0000000000408a9c in vbe_conn_try (bp=0xaf4d00, pai=0x7ffff9bcc848)
    at cache_backend.c:176
#2  0x0000000000408c74 in vbe_connect (sp=0x2a81008, bp=0xaf4d00)
    at cache_backend.c:224
#3  0x0000000000409093 in vbe_nextfd (sp=0x2a81008) at
cache_backend.c:295
#4  0x00000000004092d2 in VBE_GetFd (sp=0x2a81008) at
cache_backend.c:332
#5  0x000000000040ca50 in Fetch (sp=0x2a81008) at cache_fetch.c:278
#6  0x000000000040a094 in cnt_fetch (sp=0x2a81008) at cache_center.c:300
#7  0x000000000040b0fd in CNT_Session (sp=0x2a81008) at steps.h:40
#8  0x0000000000412aa8 in wrk_do_one (w=0x7ffff9bccad0) at
cache_pool.c:194
#9  0x0000000000412fa3 in wrk_thread (priv=0x856300) at cache_pool.c:248
#10 0x000000080098755b in ?? ()
#11 0x0000000000000000 in ?? ()
#12 0x00007ffffe5f3fd8 in ?? ()
#13 0x0000000004756a00 in ?? ()
#14 0x0000000000000000 in ?? ()
#15 0x000000000053be00 in ?? ()
#16 0x00007ffff99cf000 in ?? ()
Cannot access memory at address 0x7ffff9bcf000
(gdb) 

This is on FreeBSD/amd64 6.2-RELEASE.

Should I try trunk to see if it is any better?

On Wed, Sep 12, 2007 at 08:12:18AM +0200, phk at projects.linpro.no wrote:
> Author: phk
> Date: 2007-09-12 08:12:18 +0200 (Wed, 12 Sep 2007)
> New Revision: 1942
> 
> Modified:
>    trunk/varnish-cache/bin/varnishd/cache_pool.c
> Log:
> Make sure to initialize t_end if we drop sessions.
> 
> Fixes #132
> 
> Many thanks to Janis Putrams for debugging this.
> 
> 
> 
> Modified: trunk/varnish-cache/bin/varnishd/cache_pool.c
> ===================================================================
> --- trunk/varnish-cache/bin/varnishd/cache_pool.c	2007-09-07 11:31:18 UTC (rev 1941)
> +++ trunk/varnish-cache/bin/varnishd/cache_pool.c	2007-09-12 06:12:18 UTC (rev 1942)
> @@ -310,6 +310,7 @@
>  	    (params->wthread_max * params->overflow_max) / 100)) {
>  		VSL_stats->n_wrk_drop++;
>  		UNLOCK(&tmtx);
> +		sp->t_end = TIM_real();
>  		vca_close_session(sp, "dropped");
>  		vca_return_session(sp);
>  		return;
> 
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at projects.linpro.no
> http://projects.linpro.no/mailman/listinfo/varnish-commit


-- 
Anders.