[Varnish] #1581: Duplicate SLT_Begin log records
Varnish
varnish-bugs at varnish-cache.org
Tue Sep 9 14:54:34 CEST 2014
#1581: Duplicate SLT_Begin log records
----------------------+-----------------------------------------------
Reporter: daghf | Owner: Martin Blix Grydeland <martin@…>
Type: defect | Status: closed
Priority: normal | Milestone:
Component: varnishd | Version: trunk
Severity: normal | Resolution: fixed
Keywords: |
----------------------+-----------------------------------------------
Comment (by Martin Blix Grydeland <martin@…>):
In [f94106987fcdd958c1daf4cec6186da980c8ac82]:
{{{
#!CommitTicketReference repository=""
revision="f94106987fcdd958c1daf4cec6186da980c8ac82"
Allocate request VXID only when it's needed and delay all logging
until it's been allocated.
This patch delays the VXID allocation until the time we know that we
will actually be logging anything for this request (not completely all
whitespace noise). This keeps the code in one place only (plus the ESI
mock request handling), instead of separated between the linger wait,
cache acceptor and pipelining code paths.
Coincidentally fixes the logging of timestamps problem in #1588.
Test case by daghf.
Fixes: #1581 #1588
Conflicts:
bin/varnishd/cache/cache_esi_deliver.c
bin/varnishd/cache/cache_fetch.c
bin/varnishd/cache/cache_http1_fsm.c
bin/varnishd/cache/cache_session.c
}}}
--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1581#comment:2>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator
More information about the varnish-bugs
mailing list