[Varnish] #983: reload-vcl doesn't support all varnishd flags
Varnish
varnish-bugs at varnish-cache.org
Tue Sep 20 10:54:57 CEST 2011
#983: reload-vcl doesn't support all varnishd flags
-----------------------+----------------------------------------------------
Reporter: kane | Owner: ssm
Type: defect | Status: closed
Priority: lowest | Milestone:
Component: packaging | Version: 3.0.0
Severity: trivial | Resolution: fixed
Keywords: |
-----------------------+----------------------------------------------------
Changes (by tfheen):
* status: new => closed
* resolution: => fixed
Old description:
> Seems reload-vcl has a hardcoded list of parameters that varnishd takes,
> but at least in 2.1.5 they're out of sync. So when running reload, the
> following happens (non-fatal):
>
> $ sudo /etc/init.d/varnish reload
> * Reloading HTTP accelerator varnishd
> Illegal option -i
> ...done.
>
> The patch is trivial and inline below:
>
> --- /usr/share/varnish/reload-vcl 2011-01-27 16:24:36.000000000
> +0000
> +++ /tmp/reload-vcl 2011-08-17 01:03:06.000000000 +0000
> @@ -87,7 +87,7 @@
> # Extract the -f and the -T option, and (try to) ensure that the
> # management interface is on the form hostname:address.
> OPTIND=1
> -while getopts a:b:dFf:g:h:l:n:P:p:S:s:T:t:u:Vw: flag $DAEMON_OPTS
> +while getopts a:b:CdFf:g:h:i:l:M:n:P:p:S:s:T:t:u:Vw: flag $DAEMON_OPTS
> do
> case $flag in
> f)
New description:
Seems reload-vcl has a hardcoded list of parameters that varnishd takes,
but at least in 2.1.5 they're out of sync. So when running reload, the
following happens (non-fatal):
$ sudo /etc/init.d/varnish reload
* Reloading HTTP accelerator varnishd
Illegal option -i
...done.
The patch is trivial and inline below:
--- /usr/share/varnish/reload-vcl 2011-01-27 16:24:36.000000000
+0000
+++ /tmp/reload-vcl 2011-08-17 01:03:06.000000000 +0000
@@ -87,7 +87,7 @@
# Extract the -f and the -T option, and (try to) ensure that the
# management interface is on the form hostname:address.
OPTIND=1
-while getopts a:b:dFf:g:h:l:n:P:p:S:s:T:t:u:Vw: flag $DAEMON_OPTS
+while getopts a:b:dFf:g:h:l:n:P:p:S:s:T:t:u:Vw: flag $DAEMON_OPTS
do
case $flag in
f)
--
Comment:
Fixed in:
commit 00a71725e497ed0be6d25165160c3fd076973d08
Author: Tollef Fog Heen <tfheen at varnish-software.com>
Date: Tue Sep 20 10:54:26 2011 +0200
Add missing options to reload-vcl to allow -C, -i, -M.
Fixes Varnish trac: #983
--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/983#comment:3>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator
More information about the varnish-bugs
mailing list