[Varnish] #1023: If all idle clients stay idle, none of the idle connections are closed when they timeout.
Varnish
varnish-bugs at varnish-cache.org
Tue Sep 20 04:16:48 CEST 2011
#1023: If all idle clients stay idle, none of the idle connections are closed when
they timeout.
---------------------+------------------------------------------------------
Reporter: drwilco | Type: defect
Status: new | Priority: normal
Milestone: | Component: varnishd
Version: 3.0.0 | Severity: normal
Keywords: |
---------------------+------------------------------------------------------
https://www.varnish-
cache.org/trac/browser/bin/varnishd/cache_waiter_poll.c?rev=c10599526e8f43d9c999a470d530f643752d2564#L147
That little if right there makes it so if the poll returns 0 (no idle
clients did anything) the connection isn't closed. This is potentially
bad, and is not in line with the other waiters' behavior.
Simplest thing would be to remove lines 147 & 148. The whole waiter could
probably use a rewrite to go through the idle connections a bit more
efficiently, like the other waiters do. But do people actually use the
poll() waiter?
--
Ticket URL: <https://www.varnish-cache.org/trac/ticket/1023>
Varnish <https://varnish-cache.org/>
The Varnish HTTP Accelerator
More information about the varnish-bugs
mailing list